Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds GH action for MMI #23778

Merged
merged 39 commits into from
Apr 17, 2024
Merged

chore: adds GH action for MMI #23778

merged 39 commits into from
Apr 17, 2024
+48 −0

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Mar 28, 2024 •
edited
Loading

Description

Creates a GH action to automatically notify MMI team members in order to have immediate visibility of what’s to come and test/review.

Meaning, it will automatically notify us to our extension slack channel, when a PR with the "team-mmi" tag is merged to develop.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Mar 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9455a78]
Page Load Metrics (548 ± 457 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint683651147335
domContentLoaded9441884
load552767548952457
domInteractive9441884
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (01a4d60) to head (983c497).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #23778   +/-   ##
========================================
  Coverage    67.59%   67.59%           
========================================
  Files         1245     1245           
  Lines        48834    48834           
  Branches     12762    12762           
========================================
  Hits         33008    33008           
  Misses       15826    15826

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live marked this pull request as ready for review April 1, 2024 11:03
@zone-live zone-live requested a review from a team as a code owner April 1, 2024 11:03
@zone-live zone-live requested a review from Gudahtt April 1, 2024 11:03
@metamaskbot
Copy link
Collaborator

Builds ready [1686f4c]
Page Load Metrics (920 ± 537 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint683541516933
domContentLoaded1075342110
load5528799201119537
domInteractive1075342110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live added team-mmi PRs from the MMI team and removed team-mmi PRs from the MMI team labels Apr 3, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [fffd2e0]
Page Load Metrics (810 ± 479 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723291245627
domContentLoaded125824126
load592464810998479
domInteractive125824126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d27db18]
Page Load Metrics (1056 ± 581 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722131254019
domContentLoaded116926147
load58337310561209581
domInteractive116926147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [66fd713]
Page Load Metrics (1252 ± 506 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint642991335325
domContentLoaded989362411
load52239612521053506
domInteractive989362411
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [fad9312]
Page Load Metrics (1152 ± 619 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint823221457134
domContentLoaded1210027209
load67301111521290619
domInteractive1210027209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f106a1e]
Page Load Metrics (1442 ± 662 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint724021569546
domContentLoaded105322105
load60352014421378662
domInteractive105322105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [983c497]
Page Load Metrics (728 ± 552 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63155942412
domContentLoaded96122147
load5231837281149552
domInteractive96122147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live requested a review from davidmurdoch April 16, 2024 15:23
@zone-live zone-live merged commit 48a7969 into develop Apr 17, 2024
70 of 71 checks passed
@zone-live zone-live deleted the MMI-4847-gh-action-autotag-mmi-team branch April 17, 2024 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 17, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legobeat legobeat legobeat left review comments

@albertolive albertolive albertolive approved these changes

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-mmi PRs from the MMI team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zone-live @metamaskbot @davidmurdoch @albertolive @legobeat @gauthierpetetin